Release: Cherry-pick bug fixes from Gutenberg 6.7 into WordPress 5.3 release#17951
Merged
Conversation
* Update dropdown menu items to match hover style in other places * Remove focus selector from hover styles declaration
* Change z-index override logic for popovers. * Undo gradient formatting. * Remove import of deleted file. * Remove empty file, fix reference to deleted zindex
#17712) * Plugins: Ensure sidebar plugins do not get auto-closed when opened on small screens * Tests: Add e2e test which ensures that the plugin sidebar gets operned on medium screens * update tests due to new expectations. With the fix implemented in the tested hook, expecations for initial state of the hook changes since the effect bails early when the current state of `isSmall` from the viewport store matches the previous state stored on the ref. On initial render, this hook will always bail early. I also added some inline comments to help explain what is happening in the test and what is expected. * fix code style issue * Add changelog entry for edit-post package
…`lint-js` command (#17744)
…ds (#17746) * Scripts: Use the latest version of webpack for build and start commands * Add changelog entry for webpack upgrade in `@wordpress/scripts` * Update failing tests by regenerating snapshots where hashes produces by webpack changed
* Update getDerivedStateFromProps to pass back all state property changes * Add test to check that state.opensInNewWindow is set correctly on prop change * Rename test file
* Update mixing that sets hover style on some buttons * Add popover hover styles to match updates from #17621
* Core Data: Fix redo behavior and expand test coverage. * e2e test: compare text content instead of matching snapshots
* List Block: fix merging with indented list items * Fix forward merge
* Bump plugin version to 6.6.0-rc.1 * Typewriter: use DOMRect.top to fix for Edge (#17707) * Bump plugin version to 6.6.0 * Bugfix for wrong isObjectActive flag Right now isObjectActive is set as true for every existed replacement. Thats why any custom replacements has PopoverAtImage * Bugfix for wrong isObjectActive flag Right now isObjectActive is set as true for every existed replacement. Thats why any custom replacements has PopoverAtImage
When toggling between Bulleted List and Numbered List, the Block Controls for List block disappears. You have to click inside the block to get them back. Ideally, the Block Controls should always be present, if the block is selected.
Left aligned blocks should not inherited "float:left" to nested blocks. In reference to #17793
* Packages: Add information for webpack about no side effects * Update README.md
* Redo: add failing e2e tests * Core Data: Don't lose flattened undos when undoing before timeout.
gziolo
requested review from
SergioEstevao,
Soean,
TimothyBJacobs,
dmsnell,
ellatrix,
etoledom,
jorgefilipecosta,
mkaz,
mmtr,
nerrad,
noisysocks,
ntwb,
talldan and
youknowriad
as code owners
Member
Author
|
Travis looks really bad. I will investigate. |
youknowriad
approved these changes
Oct 15, 2019
gziolo
force-pushed
the
wp/trunk-6.8-release
branch
from
ea88a42 to
59f536f
Compare
Member
Author
|
The color palette is broken:
@jorgefilipecosta - can you help investigate? DropIt icons look good:
|
Member
Author
|
It looks like Image block preview should have the image size provided:
|
Contributor
|
@gziolo The image preview is a known bug, basically once the image is loaded, next time you hover, it's fixed. |
* Update 'Heading › it should correctly apply named colors' test for Twenty Twenty * Update 'TypeWriter' tests for Twenty Twenty * Update 'Font Size Picker › should apply a named font size using the font size input' test for Twenty Twenty * Update 'Preview with Custom Fields enabled › displays edits to the post title and content in the preview' test for Twenty Twenty * Fix 'Managing reusable blocks › Should import reusable blocks' test * TypeWriter E2E tests: Use <= instead of <
There was a change to the named font sizes in twentytwenty: WordPress/twentytwenty#764 This updates the tests to use the new value in the theme
Member
I added a commit that fixes the issue, we were removing color pallete styles in a commit but in this branch, the styles are still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis should be green and @youknowriad should review all commits applied.
There were some issues applying #17696. We need to retest:
z-indexz-index– test by checking that the toolbar of the image caption shows properlyPinned plugins should be re-tested as well with the DropIt plugin. Check more in #17752.