Fix watching e2e tests#18391
Merged
Merged
Conversation
gziolo
approved these changes
Nov 8, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I missed that, sorry about the trouble and thanks for fixing. I'm glad you are using this feature in your workflow 💯
gziolo
added
the
[Type] Automated Testing
Contributor
Author
|
@gziolo, you fix so many other things so no need for an apology! Thanks for reviewing and merging ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#18003 removed
npm run test-e2e:local, but it was still being used bynpm run test-e2e:watch, causing that script to fail. This change resolves that issue.How has this been tested?
npm run test-e2e:watchTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: