Project Management Automation: Call core setFailed with error message#20012
Merged
Conversation
epiqueras
approved these changes
Feb 3, 2020
Member
Author
|
This time it failed, as expected (in other words, "works as expected"): https://github.com/WordPress/gutenberg/runs/423916394?check_suite_focus=true I'll now merge #20011 to fix the existing issue with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #20009
This pull request seeks to reintroduce error handling removed as part of #20009. This time, it seeks to report the error using
setFailedfrom the@actions/corepackage. This is also consistent with other usage a few lines above where a failure of a missing token is reported using this means.https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-a-javascript-action#write-the-action-code
gutenberg/packages/project-management-automation/lib/index.js
Lines 34 to 38 in 2e00995