Block Editor: LinkControl: Avoid lingering value properties from previous value#20020
Block Editor: LinkControl: Avoid lingering value properties from previous value#20020aduth wants to merge 2 commits into
Conversation
Effective `settings` must be known for picking properties to inherit.
9d5cc29 to
1edf787
Compare
|
I tried to test this following the testing instructions but the Also, I was struggling to follow the purpose here. If we create a link, and then decide to change it to something else I thought we'd want to keep any existing settings (eg: "new tab") in place. For example, say I enter a link and then set it to open in a new tab, and then I realise I made a typo and meant I'm not 100% sure it this is what you are intending or whether I've got completely the wrong end of the stick. I feel like I could be missing something here... |
|
With #19775 merged we will still need to deal with this. Sorry it perpetuated the issue a little. I'm happy to help review if I can help. |

Related: #19827
This pull request seeks to resolve an issue introduced by #19651, where if a link is assigned a value with an associated
title(or any other supportedvalueproperties), they will be inherited into the next value when the user manually enters a URL. This ties in to related work at #19827, where ideally the suggestion value shapes are made to be consistent. As of #19651, the form submit handler will only assign theurlproperty of the next value.Even with separate improvements to make the suggestion value consistent, the changes here may still be valuable as an expression of intent of the next value to only derive settings properties from the previous values, and no other properties.
Testing Instructions:
Verify that a title does not transfer to a newly manually-entered value:
http://example.com