Cherry Pick PR's for WordPress 5.4 RC 1#20593
Merged
Merged
Conversation
* Handle errors more robustly - Separate cases for errors we know about - More straightforward general error case * Update tests to handle the new error format
Allows the user to set `port` and `testsPort` in .wp-env.json. - Port must be a number - Ports must be different - Ports can still be overridden with the environment variables
- Fixed: docker and WP had different URLs Caused by WordPress install not using the .wp-env.json custom port values, so it would redirect you to the default port. - Added: validation function for numeric env vars - Added: tests to validate port override behavior
- Uses a non-hidden default directory for Linux (~/wp-env) - Allows a user to override the directory in which wp-env creates generated files with the WP_ENV_HOME environment variable. Work towards #20180, but will need to continue in a follow-up.
* Env: Add debug flag. * Env: Log Docker commands in debug mode. * Env: Log Git commands in debug mode. * Env: Log config and Docker Compose file in debug mode and log using the spinner.
* Env: Add support for local override files. * Document
…#20340) * Env: Check for legacy installs and provide the option to delete them. * Fix tests.
* Env: Support wp-config.php overrides. * Env: Move WORDPRESS_DEBUG to work through the new config. * Fix bugs. * Handle string values.
* @wordpress/env: Fix testsPath on local sources When using a local source (e.g. ~/path/to/wordpress), the tests WordPress directory should be at ~/.wp-env/$hash/tests-wordpress instead of ~/path/to/tests-wordpress. * @wordpress/env: Show debug output from docker-compose stop in wp-env start
The www-data user in wordpress:cli has a different UID (82) to the www-data user in wordpress (33). Ensure we use the wordpress www-data user for CLI commands. See docker-library/wordpress#256 for more discussion.
Makes the WordPress content directories (wp-content, wp-content/plugins, wp-content/themes) owned by the www-data user. This ensures that WordPress can write to these directories. This is necessary when running wp-env with `"core": null` because Docker will automatically create these directories as the root user when binding volumes during `docker-compose up`, and `docker-compose up` doesn't support the `-u` option. See docker-library/wordpress#436.
* Editor: Shim meta attributes for early block registrations * E2E Tests: Add meta block early registration test * Editor: Clarify comment regarding meta attribute shim
Co-Authored-By: Christian Wood <cwood821@users.noreply.github.com> Co-authored-by: Christian Wood <christian@christianwood.net>
jorgefilipecosta
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
daniloercoli and
dmsnell
as code owners
jorgefilipecosta
requested review from
SergioEstevao,
Soean,
TimothyBJacobs,
ellatrix,
etoledom,
gziolo,
karmatosed,
mapk,
mkaz,
mkevins,
mmtr,
nerrad,
noisysocks,
ntwb,
oandregal,
pinarol,
swissspidy,
talldan and
youknowriad
as code owners
Member
|
From the build failure, it appears it may be affected by the same issue intended to be fixed by #20547, since the It may be necessary to cherry-pick the commit of that pull request as well, in order for the build to pass. |
* adds a filter that sets the excerpt length to what was set in the editor * adds named function as excerpt filter and removes after use * adds PHP doc to the new filter callback and global variable * default to using an anonymous function since it appears that it can be remove and is not affecting theme set length * revert to named function for excerpt length filter * proper function names for Guternberg namespace * lower default priority for the latest posts excerpt length filter
* Rich Text: Avoid activeElement focus call * Rich Text: Restore focus, accounting for null activeElement * Rich Text: Verify activeElement instanceof HTMLElement
aduth
approved these changes
Mar 2, 2020
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I can only confidently speak to changes of my own involvement, but in looking through the changes and a smoke-test of the editor and especially changes I was involved with, this looks in good shape to me 👍
Member
Author
|
Thank you for the review @aduth! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry picks the following PR's into wp/trunk:
These PR's will be part of WordPress 5.4 RC 1.
How has this been tested?
I did some smoke tests and verified the branch, in fact, contained the expected fixes.