URL: Fix getQueryString incorrect handling of hash fragment#20738
Merged
Conversation
aduth
added
[Type] Bug
|
Size Change: +353 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
Member
Author
|
As seen with the changes in 0a6046a, the new implementation is slightly more strict in regards to assuming the input argument to be a proper URL, not merely any string which happens to contain
|
gziolo
approved these changes
Mar 12, 2020
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It looks correct. I hope it doesn’t break anything in projects that depend on this bug 😅
Previously _sort of_ existed, but as an invalid URL which would fail to construct as `new URL` in the current implementation. Now split to two assertions verifying "invalid URL" behavior and "empty querystring" behavior.
Member
Author
Note that I had to scale this back a bit in #20693. Specifically, there's at least a few occurrences where we rely on an implementation like this: addQueryArgs( '/wp-json/wp/v2/posts`, { type: 'post' } );And if The solution (8dfe648) is a bit hacky, effectively treating the input URL as the path of a throwaway base (second argument of URL constructor). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #11286
Extracted from: #20693
This pull request seeks to fix an incorrect behavior of
@wordpress/urlgetQueryString, where a result may be returned when a?is encountered within the hash fragment of a URL:A hash fragment is always the last segment of a URL, and the querystring must always precede it (see reference specification).
Testing Instructions:
Ensure unit tests pass: