Revert #20658 due to issues with image placement and selection#21160
Closed
roo2 wants to merge 1 commit into
Closed
Revert #20658 due to issues with image placement and selection#21160roo2 wants to merge 1 commit into
roo2 wants to merge 1 commit into
Conversation
… due to issues: WordPress#21152 WordPress#21114 This reverts commit 8a94254.
roo2
requested review from
Soean,
ajitbohra,
ellatrix,
jorgefilipecosta,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
roo2
changed the title
This was referenced Mar 26, 2020
Contributor
|
It would be good to try to understand the difference in markup causing this issue. There's already some PRs building on top of this change. Notably #20721 |
Member
|
I don't like that we're reverting this. Let's at least try to fix the issues first. |
ellatrix
requested changes
Mar 26, 2020
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Ok, allow me some time to investigate. :)
Contributor
Author
|
Ahh yep I see the more thorough fix 21167, maybe I was a bit hasty to make this the other night :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We deployed Gutenberg 7.7.1 to live sites and had reports of issues with image selection from users, github issues:
#21152
#21114
I tracked it down to being introduced by #20658
I wasn't able to quickly solve the issue surgically, so for now I would like to revert the entire changeset. I'm currently testing the revert locally and all seems fine, it looks like the commit was refactoring and other code hasn't built on top of it yet 😄
Description
Reverts #20658
How has this been tested?
Currently going through the affected elements and testing their behaviour WRT positioning and selectability. It fixes the image issues originally identified:
I Created a test of blocks that may have been affected:
Checklist:
fixes #21152, fixes #21114