Editor: Fix "Attempt Recovery" error boundary handler#22396
Closed
aduth wants to merge 2 commits into
Closed
Conversation
aduth
added
[Type] Bug
|
Size Change: -152 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
Member
Author
|
Closing as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where "Attempt Recovery" (shown in the top-level error boundary) will never work correctly.
Status: In progress. The change in a27c055 fixes the issue. However, I'm not particularly confident this is the best solution.
The issue:
EditorProviderskips most of its state initialization, since the state will have been preserved from before the error happens.EditorProvidercomponent unmounts (notably, theisReadystate).! isReadystate and never initialize out of it (source)The fix:
! isReadyto! isReady || recovery, such that the editor renders in recovery modePossible alternatives:
isReadyaltogetherisReadywhen performing editor teardownisReady