chore: Temporarily skip failing test#22447
Merged
Merged
Conversation
jorgefilipecosta
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Member
|
Possibly a selector changed in the edit-site header? |
Member
|
I'll look at it locally :) |
Member
Author
|
Thank you a lot for debugging this issue @noahtalle :) |
Member
|
The selector appears to be adding a block in the wrong area. Should be easy to fix, PR up soon! |
Member
|
Specifically, I think the issue comes from this line in the PR you mentioned, which makes the inserter insert the block at the selection end. https://github.com/WordPress/gutenberg/pull/22140/files#diff-c6139f159c9b2b79af303587407aea51R170 When I wrote the test, I was relying on it inserting the block at the end of the document outside of the template part I had been previously editing. :) Here's what it looks like with that change:
Previously, the block was inserted outside of the template part, but now it is inside the template part. |
6 tasks
Member
|
#22448 will fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily skips a failing end to end test.
It seems it may have started to fail here #22140. But that PR does not seems related to the test that is failing.
cc: @noahtallen as the original test author in case you have some insights on why the test is now failing.