Post Tags: Feature Parity for Customization#24069
Merged
Addison-Stavlo merged 9 commits intoAug 3, 2020
Merged
Conversation
12 tasks
6 tasks
Member
Contributor
Addison-Stavlo
left a comment
There was a problem hiding this comment.
Since there is currently no style hook for textAlign, we will need to ensure the proper class is added in the index.php file for this block.
Similar to:
gutenberg/packages/block-library/src/post-comments/index.php
Lines 34 to 37 in 799e355
Contributor
Author
|
Note:
After more consideration, we'll be handling these concerns at a later date. |
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a task in #21087 and is meant to add feature parity to FSE blocks. This adds settings (and some necessary restructuring/styles to support) text alignment and the experimental flags for color, fontSize, and lineHeight.
How has this been tested?
Tested on local docker wp-env environment.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: