Remove WP_Widget_Block from the legacy dropdown list#24787
Merged
noisysocks merged 1 commit intoAug 26, 2020
Conversation
adamziel
added
the
[Feature] Widgets Screen
20 tasks
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Contributor
|
@adamziel I wonder, could we make it that the Block widget does not show in the available widgets in the current widgets screen, but still shows up in the areas if used? :) I ask because the WP_Widget_Block adds this "Block" entry that does not provide any action in the current widgets screen. |
Member
+1 good idea. It looks like we might need to patch Core to do this, though, as I'm not seeing any filters we can use in |
noisysocks
deleted the
update/fix-block-showing-up-in-legacy-widget-dropdown
branch
Contributor
Author
|
Great idea @draganescu ! I created an issue to track it here: #24849 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #24290 (comment), this is what happens when you add a legacy widget on the experimental management screen:
Before:
This is undesired, the Block widget shouldn't be visible to the user, it's just an implementation detail to ensure interoperability. This PR removes it from that dropdown like this:
After:
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: