[Experimental widgets screen] Remove "id" attribute of the legacy-widget block#24817
Merged
Conversation
adamziel
added
[Feature] Widgets Screen
20 tasks
|
Size Change: +39 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
adamziel
changed the title
adamziel
changed the title
draganescu
approved these changes
Aug 27, 2020
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Tested locally and it works. Also code looks mildly complex if you run into it without this context (especially getWidgetIdForClientId) but I don't have another way or solution :) 🚢
Contributor
Author
|
@draganescu agreed, at the same time it's the same pattern as on the navigation screen - to make this screen truly extendable there needs to be an API to match widget Id with it's corresponding client Id. The good news is that if it ends up being confusing, it should be pretty easy to refactor before the beta, it's a pretty small part of the system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As @noisysocks mentioned in his comment:
The culprit is that widgets are saved using data from their attributes. ID is one such attribute, and once the block is duplicated there are two blocks with the same ID. This PR removes the ID attribute entirely, replacing it with pulling the widget ID correlated with the block ID from the data store. It also removes the dependency of the save function on the
numberblock attribute. Note that thenumberattribute could potentially be removed entirely in a subsequent PR.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: