Block API: stabilize light block hook#25642
Merged
Merged
Conversation
ellatrix
requested review from
Soean,
ajitbohra,
ajlende,
mkaz,
talldan and
youknowriad
as code owners
youknowriad
reviewed
Sep 25, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I agree it's stable enough but the other question is whether we'd also rename the "lightBlockWrapper": true as apiVersion: 2 top-level on the settings in order to be able to do similar changes on the future?
Member
Author
|
I like versioning it |
ellatrix
force-pushed
the
try/stabilize-light-block
branch
2 times, most recently
from
85fd04c to
d2d432d
Compare
|
Size Change: -41 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
ajitbohra
reviewed
Sep 25, 2020
Member
Author
|
The only thing needed before stabilisation is #25644. |
Member
|
I like the idea of an |
youknowriad
reviewed
Sep 25, 2020
ellatrix
force-pushed
the
try/stabilize-light-block
branch
2 times, most recently
from
b3d24ff to
28c1c86
Compare
youknowriad
reviewed
Sep 25, 2020
youknowriad
added
[Feature] Block API
ellatrix
force-pushed
the
try/stabilize-light-block
branch
2 times, most recently
from
5b4697a to
1375643
Compare
youknowriad
approved these changes
Sep 28, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
This is looking good for me.
I think we'd need some good documentation about this for the release and in the handbook.
mcsf
approved these changes
Sep 29, 2020
ellatrix
force-pushed
the
try/stabilize-light-block
branch
3 times, most recently
from
8dd382f to
7b23e31
Compare
ellatrix
force-pushed
the
try/stabilize-light-block
branch
from
7b23e31 to
8db8143
Compare
6 tasks
gziolo
reviewed
Oct 15, 2020
|
|
||
| Undocumented declaration. | ||
|
|
||
| <a name="useBlockProps" href="#useBlockProps">#</a> **useBlockProps** |
Member
There was a problem hiding this comment.
Noting that useBlockProps.save isn't documented. I guess it's too late to expose it under its own name.
Contributor
There was a problem hiding this comment.
We discussed this and we preferred to use that notation because we'll have the same thing for innerblocks, richtext, and each one of this have a version for edit and for save.
And we plan to document this properly see the PR description here #26100
Member
There was a problem hiding this comment.
Cool, makes sense to follow the same pattern, although it isn't ideal moving forward :)
Member
Author
There was a problem hiding this comment.
What's not ideal moving forward?
Member
There was a problem hiding this comment.
The dot notation that takes advantage of the fact that a function is also an object in JS.
tellthemachines
removed
the
Needs Dev Note
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blocked by #25644.
This is solid and ready to be used by plugins.
Remaining questions:
Rename toYesuseBlockProps? Inner blocks: try hook approach #25633 (comment)Keep theVersionlightBlockWrappersupports key or introduce versioning?After this we should update documentation with the new recommended API, e.g. https://developer.wordpress.org/block-editor/developers/block-api/block-edit-save/.
How has this been tested?
Screenshots
Types of changes
Checklist: