Skip to content

change in useDispatch documentation to fit #27088#27097

Closed
grzim wants to merge 1 commit into
WordPress:masterfrom
grzim:refactor/documentation-to-replace-hardcoded-store-keys-with-store-definitions
Closed

change in useDispatch documentation to fit #27088#27097
grzim wants to merge 1 commit into
WordPress:masterfrom
grzim:refactor/documentation-to-replace-hardcoded-store-keys-with-store-definitions

Conversation

@grzim
Copy link
Copy Markdown
Contributor

@grzim grzim commented Nov 19, 2020

Description

Fix the documentation according to changes in #27094

How has this been tested?

Documentation fix

Types of changes

Documentation fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@grzim grzim requested a review from nerrad as a code owner November 19, 2020 11:17
@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 19, 2020
@adamziel adamziel added [Package] Data /packages/data [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Nov 19, 2020
@adamziel adamziel requested a review from gziolo November 19, 2020 11:18
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Nov 19, 2020

There is an issue reported by ESLint that can be fixed with Prettier: npm run format-js

https://github.com/WordPress/gutenberg/pull/27097/checks?check_run_id=1423788415#step:6:116

I think I have the same changes included in #27061, but we can merge this one if it's faster earlier 😄

@gziolo
Copy link
Copy Markdown
Member

gziolo commented Nov 19, 2020

I merged #27061 so I close this one as a duplicate. Thanks for opening this PR regardless.

@gziolo gziolo closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Data /packages/data [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants