Release: v9.5.1#27580
Merged
Merged
Conversation
* Revert "Fix c and r formats, add tests." This reverts commit 1f73702. * Revert date changes from branch 'replace-moment' * fix merge error
Fix an issue where the `Popover` component throws a runtime `TypeError: Cannot read property 'getBoundingClientRect' of undefined.` This may happen in WordPress if a Popover is rendered in an iframe. It's been observed by rendering a `BlockList` component containing `RichText` in an iframe 😵 The issue is that `instanceof` checks fail across iframe boundaries, where `anchorRef instanceof window.Element` fails because `anchorRef` when it _is_ an instance of Element in the frame but not `window.Element`. Instead of `instanceof` checks that fail across iframe boundaries, check for expected methods as the predicate.
|
Size Change: +20.6 kB (1%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 8, 2020
WunderBart
requested review from
ajitbohra,
chrisvanpatten and
nerrad
as code owners
Contributor
|
Actually, this PR is targetting the wrong branch, it should target release/9.5 Edit: Nevermind, I got confused by the name of the branch itself :) |
Contributor
|
Looks like there's a small package.lock diff that might be good to fix to get the tests passing |
Member
Author
@youknowriad, this one's actually a bit confusing to me (https://github.com/WordPress/gutenberg/runs/1518139432?check_suite_focus=true) - shouldn't it be running |
Contributor
|
Ideally we don't name temporary branches |
Contributor
|
@WunderBart I thought there's a valid reason for this check to not run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked bugfix PRs for a patch release: