Fixed tooltip overflow in modal(issue: #28311)#28415
Closed
IslamYehia1 wants to merge 1 commit into
Closed
Conversation
IslamYehia1
requested review from
ajitbohra and
chrisvanpatten
as code owners
github-actions
Bot
added
the
First-time Contributor
Member
|
Hi, thank you for the contribution. It looks like this was overlooked and similar changes to the modal were made in #31639 I'm going to close this ticket, if there is anything missing with the updated modal. Please open a new ticket to address and I'll be glad to review them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed tooltip overflow in modal. The CSS on the class .components-modal__frame had a Transform property to center align the modal frame which would change the correct behavior of the popover(tooltip) positioning, since the popover has the property position: fixed.
How has this been tested?
Tested on Chrome, Firefox, and Edge.
Screenshots
Types of changes
Removed the transform property and changed the display property on the parent parent .components-modal__screen-overlay to flex, and center aligned the contents.