Docs: Add new page for i18n filters#28553
Merged
Merged
Conversation
leewillis77
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
Member
|
Thank you for starting this PR ❤️ |
gziolo
added
[Type] Developer Documentation
JustinyAhin
reviewed
Jan 29, 2021
Member
|
@leewillis77 the PR looks good to me. I've just added a small phrasing suggestion |
JustinyAhin
approved these changes
Jan 29, 2021
gziolo
approved these changes
Jan 29, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I marked 3 places where some enhancements could be applied but overall it looks great 👍🏻
|
|
||
| ## Filter Arguments | ||
|
|
||
| The filters are passed the following arguments, in line with their PHP equivalents. |
Member
There was a problem hiding this comment.
It would be nice to link with the corresponding PHP documentation page.
Contributor
Author
There was a problem hiding this comment.
I'm not aware of a single place we could link to that covers all of the relevant PHP filters (they each have their own page), so decided not to add links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for the filters added in #27966