build-worker: call callback with error when no task for extension#28723
Merged
Conversation
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
sirreal
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
build-workercannot find a task handler for a given file extension, it should call thecallbackwith error. This can happen when we want to build a file with an unsupported extension, e.g.,.tsx. In such case, the build process hanged forever, because the async task never called its completion callback.Spinoff from #28465 where I encountered this bug when trying to add TypeScript support.