Hooks: export the defaultHooks singleton instance#28725
Merged
Conversation
|
Size Change: +8 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Feb 4, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It should be documented in the README file, too.
Otherwise, it’s a good addition 👍
Member
Author
Fixed in a9be0f6 🚀 |
jsnajdr
force-pushed
the
add/hooks-default-instance
branch
from
a9be0f6 to
8881f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to exporting hooks methods one by one, this PR also exports the default hooks instance as a whole, under the
defaultHooksname.The immediate use case will be passing it as a
hooksparameter to acreateI18nfactory function in@wordpress/i18n. TheI18nclass uses multiple hooks methods, likeaddAction,removeActionorapplyFilters.Spinoff from #28465.