Add full and wide align controls to Query and Query Pagination blocks#29289
Closed
ntsekouras wants to merge 3 commits into
Closed
Add full and wide align controls to Query and Query Pagination blocks#29289ntsekouras wants to merge 3 commits into
full and wide align controls to Query and Query Pagination blocks#29289ntsekouras wants to merge 3 commits into
Conversation
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
aristath,
carolinan,
ianstewart,
jasmussen,
kjellr,
mtias and
youknowriad
youknowriad
reviewed
Feb 24, 2021
| } ), | ||
| } ); | ||
| }; | ||
| if ( align ) extraBlockProps[ 'data-align' ] = align; |
Contributor
There was a problem hiding this comment.
why d we need this? Isn't it done automatically in the hooks?
youknowriad
reviewed
Feb 24, 2021
youknowriad
reviewed
Feb 24, 2021
| } | ||
| } | ||
| if ( isset( $block->context['align'] ) ) { | ||
| $classnames .= " align{$block->context['align']}"; |
Contributor
There was a problem hiding this comment.
Isn't this something that can be applied automatically by the the support flag?
Contributor
Author
There was a problem hiding this comment.
Check my comment about the attributes. This is what we had discussed about layout as well, so align goes to Query now.
|
Size Change: +103 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Member
|
Agreed with the followup comment — we'd need to figure out what absorb in toolbar and passthrough mean in terms inner block properties. Making a wrapper be invisible or partially invisible (in the context of not affecting layout) is one of the oldest issues in #7694 |
carolinan
approved these changes
Feb 24, 2021
Contributor
carolinan
left a comment
carolinan
left a comment
There was a problem hiding this comment.
I have nothing to add to the code review.
The PR solves the problem described in the issue.
Full width and wide blocks inside a query loop appear with the correct widths inside the editor.
ntsekouras
force-pushed
the
add/query-alignment-support
branch
from
3a32bee to
cf38730
Compare
aristath
approved these changes
Mar 16, 2021
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
This looks OK to me, it just needs to be rebased before merging 👍
Contributor
Author
|
Thanks for reviewing!
Besides rebase and a small change to the selectors (not use |
Contributor
PR has been merged so I assume this PR can be rebased and adjusted and then merged. |
Contributor
Author
Yes, it must be in combination with adding a wrapper for Query block. |
Contributor
Author
|
Closing in favor of: #30804 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #27589
This PR adds
full and widealign support toQuery/QueryLoopandQuery Paginationblocks.Ideally we would want to handle this with a mechanism for
absorbingthe toolbar of nested block wrappers as described in this issue: #7694.That's why I haven't used the
supports.aligninQueryLoopand created an adhoc toolbar control foraligninQueryblock. This is a UI choice for better user experience.How has this been tested?
Manually by adding
QueryandQuery Paginationblocks and try different combinations ofalignoptions.Checklist: