Clean up bundled pattern titles & categories#30998
Merged
Merged
Conversation
kjellr
added
[Type] Code Quality
Comment on lines
8
to
11
Contributor
There was a problem hiding this comment.
I was registering these inside the init filter because if I didn't I was getting an error while the admin was loading, but I don't see that any more
Contributor
There was a problem hiding this comment.
I'm not sure registering these categories is needed, except for query that doesn't exists in core. Also not introduced in this PR, but the registration of the other categories might not be needed.. Will look now..
|
Size Change: +19 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
MaggieCabrera
force-pushed
the
update/block-pattern-categories
branch
from
5e78de3 to
a50313d
Compare
MaggieCabrera
approved these changes
Apr 20, 2021
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
This LGTM, I just rebased since I think that's all it's needed for the tests to go green.
ntsekouras
reviewed
Apr 20, 2021
| } | ||
|
|
||
| register_block_pattern_category( 'buttons', array( 'label' => _x( 'Buttons', 'Block pattern category', 'default' ) ) ); | ||
| register_block_pattern_category( 'columns', array( 'label' => _x( 'Columns', 'Block pattern category', 'default' ) ) ); |
Contributor
There was a problem hiding this comment.
It seems that the registration of categories happens in core:
https://github.com/WordPress/wordpress-develop/blob/master/src/wp-includes/block-patterns.php#L42
and we do not unregister the categories, only the core patterns.
I think it's okay to remove these registrations and the above, except query that is not in core.
Was any specific reason for these lines @MaggieCabrera ?
Contributor
There was a problem hiding this comment.
yeah, initially they were named differently and then they ended having the same names as the ones on core, so I'd say we can remove the duplicates, yes
Contributor
Author
There was a problem hiding this comment.
Cool, I've removed them in 3c3cea8 and it seems to work fine. Mind giving the PR one last look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor followup from #30763, #29973, and #30469.
This PR: