Make link UI rich previews target agnostic and fix unwanted preview for internal URLs#32658
Merged
Merged
Conversation
getdave
requested review from
kevin940726 and
youknowriad
and removed request for
ellatrix
getdave
added
[Feature] Link Editing
7 tasks
|
Size Change: +266 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Contributor
Author
|
I am aware that all the unit tests are broken. I can fix these as soon as I get a 👍 on the overall direction here. |
kevin940726
reviewed
Jun 15, 2021
Member
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
Mostly looks good! I'm okay as long as it unblocks things and fixes the bug. We can create follow-up PRs if necessary 👍 .
getdave
force-pushed
the
update/link-ui-rich-previews-apis-and-bugs
branch
from
f69622c to
16b7d61
Compare
kevin940726
approved these changes
Jun 16, 2021
Member
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
LGTM 👍 Just a small question.
Contributor
Author
|
Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has two purposes:
#1, slightly refactor the rich data APIs to make them less external URL specific. This has the advantage of fixing#1and also preparing the link UI for showing rich previews of internal URLs in the future.Note: changes to test solely down to renaming of the main fetch function.
Closes #32657
Questions
@youknowriad Where do you think the newfetchRichUrlDatafunction should reside? I was thinking@wordpress/core-data?Suggest we ship "as is" and revisit where to move the function in a followup.
How has this been tested?
Automated Testing
I will add unit tests for the
fetchRichUrlDataonce we have found a suitable home for it.Manual testing instructions
www.wordpress.org).www.wordpress.org?qs=http://localhost:8888).tel:123456).Screenshots
Screen.Capture.on.2021-06-14.at.11-53-07.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).