interface: migrate the toggleFeature action to a thunk#35075
Merged
Conversation
|
Size Change: -17 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Member
|
@jsnajdr, if I remember correctly, the current Persistence plugin doesn't work with Unfortunately, I don't have details on why it doesn't work. Just that I had this issue when implementing it for the new Navigation Screen. |
jsnajdr
force-pushed
the
migrate/interface-store-thunks
branch
from
95155d4 to
a907540
Compare
Member
Author
Oh, I get it now! The Persistence plugin intercepts the Reverted the store registration back to |
Mamaduka
approved these changes
Sep 23, 2021
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
The changes look good 👍
Tested with Widgets screen welcome guide, where toggleFeature is used for modal deactivation.
jsnajdr
force-pushed
the
migrate/interface-store-thunks
branch
from
a907540 to
5655f67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the
@wordpress/interfacedata store to thunks, removing usages of rungen generators.There is only the
toggleFeatureaction that reads the current value of a feature and flips it -- taking defaults fromstate.preferenceDefaultsinto account, and that's why the action can't be a plain action handled by a single reducer.As a drive-by fix, I'm converting
flow( [ combineReducers ] )( ... )calls to a simplecombineReducers( ... )-- there's no point in combining just a single function withflow.I'm also changing how the store is registered. In #26655 @gziolo added a comment that says:
But I don't understand what it tries to say. Both the old
registerStoreand the newregisterdo exactly the same sequence ofcreateReduxStore,store.instantiateandregisterGenericStorecalls, the newregisterversion being much simpler. Maybe something was different back in November 2020?