Identify the site frontpage in link UI search results#36493
Merged
Conversation
getdave
added
the
[Feature] Link Editing
Contributor
Author
|
This PR changes the editor settings. We need to be very careful to avoid typing performance degradation. |
|
Size Change: +142 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Contributor
|
Great idea! I tested this PR and only found this small issue with long titles:
Maybe we could add
|
getdave
commented
Nov 16, 2021
| outlineMode: hasTemplate, | ||
| __experimentalCreatePageEntity: createPageEntity, | ||
| __experimentalUserCanCreatePages: userCanCreatePages, | ||
| pageOnFront, |
Contributor
Author
There was a problem hiding this comment.
@adamziel Would you mind confidence checking me here? A previous PR I created introduced a typing performance degradation because the useMemo was recomputed too frequently. Do you see any possibility of this change causing that?
Contributor
There was a problem hiding this comment.
On the first sight it seems safe – I don't suppose pageOnFront will change that often. What's your previous PR? I'd like to compare the two.
Contributor
There was a problem hiding this comment.
I commented with my assessment there. pageOnFront seems to be be safe as it is a number, not a function (As long as it's not a NaN). Full disclosure, I didn't test it before writing this comment.
getdave
commented
Nov 16, 2021
| font-size: 0.9em; | ||
| background-color: $gray-100; | ||
| border-radius: 2px; | ||
| white-space: nowrap; // tags shouldn't go over two lines. |
getdave
changed the title
Contributor
Author
|
@javierarce I think some of the misalignment here looks less than optimal... |
Contributor
Oh, true :/ And it looks worse when the page is surrounded by more items.
I'd suggest getting rid of the icon. We could try to find a different way to highlight that particular item, but as a first step, I think we could just rely on the tag (which, now that I think about it, I think shouldn't be capitalized). |
Contributor
Author
Yeh it's a shame because felt the icon was doing a good job of highlighting it. But yes we can use Let's iterate. I need a 👍 from a tech review next because this PR touches editor settings and that's liable to introduce perf regressions. |
getdave
added
the
Needs Technical Feedback
getdave
force-pushed
the
try/mark-frontpage-in-link-ui-search-results
branch
from
39eb4bd to
50b8c0b
Compare
Contributor
Author
|
@javierarce I removed the icon and made the tag lowercase. |
javierarce
approved these changes
Jan 10, 2022
Contributor
javierarce
left a comment
javierarce
left a comment
There was a problem hiding this comment.
Checked this PR again and works fine 🚀
Contributor
Author
|
Seeking a Technical review here now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR scratches a personal itch.
When searching for a page using the Link UI it is not always clear which one of the results is your "Home" page (i.e. the one set as "Front page" in WPAdmin
Settings -> Reading.This PR updates the UI to
Front pageon that search result.This makes it a lot easier to see when you have the correct page. The primary use case is when your page is called
Homeand you search for "Home" - it's now a lot clearer that you are about to set the correct page.How has this been tested?
Home.Make me one please.Settings -> Reading.Homepage to be the Front page.Make me one pleasepage as the front page.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).