Fix duotone rendering in site editor#37727
Merged
Merged
Conversation
|
Size Change: +444 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
amustaque97
added
[Type] Bug
ajlende
added
the
Global Styles
ajlende
commented
Jan 12, 2022
ajlende
commented
Jan 12, 2022
ajlende
commented
Jan 12, 2022
ajlende
commented
Jan 12, 2022
Contributor
Author
|
@oandregal sorry it took me a while to get this up—it took me some time to understand how everything is wired up in the site editor. Because I don't feel hugely confident in how it all works, please read through it all thoroughly. Adding |
ajlende
added
the
[Feature] Site Editor
ajlende
force-pushed
the
fix/duotone-site-editor
branch
from
6bb1192 to
59ad6d2
Compare
ajlende
force-pushed
the
fix/duotone-site-editor
branch
2 times, most recently
from
6bef650 to
e386f95
Compare
ajlende
commented
Jan 25, 2022
ajlende
force-pushed
the
fix/duotone-site-editor
branch
from
e386f95 to
a493443
Compare
|
I have a user case using Twenty Twenty-two Swiss theme, where the images appeared colored in the site editor, but black and white on the live page. |
Contributor
|
I verified the issue in trunk, where filters are not seen in the site-editor, but are visible in post-editor and on the published page. When testing this branch I'm seeing a WSOD when loading the site editor, with "Objects are not valid as a React child" thrown when fetching global styles.
|
This was referenced Feb 17, 2022
ajlende
force-pushed
the
fix/duotone-site-editor
branch
from
937973a to
a86ce38
Compare
Contributor
Author
|
@gwwar I'm not seeing any WSOD in my testing. I'm running wordpress-develop trunk and this branch after rebasing with gutenberg trunk. Maybe give it another try now? |
Contributor
|
As a quick follow up note for other reviewers, the WSOD is visible when testing in Chrome but not FF. |
This reverts commit a493443.
This reverts commit b5a9098cf43d7927a4367eb201bd844a88a2dc0c.
oandregal
force-pushed
the
fix/duotone-site-editor
branch
from
eb446bd to
d75b3a5
Compare
Contributor
|
🔥 👏 |
adamziel
pushed a commit
that referenced
this pull request
Apr 25, 2022
Co-authored-by: Alex Lende <ajlende@gmail.com> Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: André <583546+oandregal@users.noreply.github.com>
Contributor
|
This was backported to wp/6.0 branch to be included in WordPress 6.0 Beta 3 tomorrow: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the site editor part of #35331
For duotone to work on the site editor we need to port the same changes introduced in the server at #34667.
How has this been tested?
styles.blocks['core/image'].filter.duotoneasvar(--wp--preset--duotone--blue-red)or a theme's duotone preset variable.Screenshots
Using TwentyTwentyTwo with the following added to theme.json:
{ "styles": { "blocks": { "core/image": { "filter": { "duotone": "var(--wp--preset--duotone--foreground-and-secondary)" } } } } }Before:
After:
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).