Add new persistence api to the preferences package#40246
Closed
talldan wants to merge 4 commits into
Closed
Conversation
|
Size Change: +134 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Will close this as the reviews are all happening on #39795. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR contains only the changes to the preferences package from #39795. It should hopefully be easier to review.
So you know where this PR fits in, #39795 demonstrates the following:
Why?
After #39632 is merged, all Gutenberg preferences will be managed by the preferences package. It has become the logical place to add this API. Doing so will finally allow us to solve #15105, which is a long standing problem for users.
Another goal is to deprecate the
registerStorefunction and the existing persistence plugin that's part of@wordpress/data(https://github.com/WordPress/gutenberg/blob/trunk/packages/data/src/plugins/persistence/README.md).How?
A new action has been added to the preferences package for configuring the persistence layer:
And in the preferences reducer a higher-order reducer is used to call the persistence layer
getandsetfunctions.Testing Instructions
The best way to test is to checkout the
try/preferences-configurable-persistence-layerbranch from #39795.Expected: top toolbar should be active