Patterns: Allow patterns within patterns to render in Block Preview#40794
Closed
inc2734 wants to merge 2 commits into
Closed
Patterns: Allow patterns within patterns to render in Block Preview#40794inc2734 wants to merge 2 commits into
inc2734 wants to merge 2 commits into
Conversation
…atterns to be empty in blockpreview
github-actions
Bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @inc2734! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Mamaduka
changed the title
Mamaduka
added
[Type] Bug
Mamaduka
reviewed
May 5, 2022
| ); | ||
| const settings = useMemo( () => { | ||
| const _settings = { ...originalSettings }; | ||
| _settings.__experimentalBlockPatterns = []; |
Member
There was a problem hiding this comment.
Thanks for contributing, @inc2734.
It looks like this was intentionally added to avoid parsing patterns in block previews - #29444 (comment).
Unfortunately, I'm not familiar with this part of the code, so maybe folks who reviewed the original PR can help us out. Cc @mcsf, @ntsekouras
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Return the correct
settings.__experimentalBlockPatternsin BlockPreview.Resolves #39732
Why?
Patterns is not rendered in BlockPreview.
How?
In BlockPreview,
settings.__experimentalBlockPatternswas overwritten with[], so that process was removed.Testing Instructions