Interface: Fix deprecation messages#40825
Merged
Merged
Conversation
Mamaduka
commented
May 4, 2022
| { | ||
| since: '6.0', | ||
| alternative: `!! wp.select( 'core/preferences' ).isFeatureActive( scope, featureName )`, | ||
| alternative: `select( 'core/preferences' ).get( scope, featureName )`, |
Member
Author
There was a problem hiding this comment.
This was an incorrect alternative suggestion.
|
Size Change: -43 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks! |
Member
Author
|
Do we want to backport this into 6.0 RC2? |
Contributor
|
I was wondering that. I think it's worth it. |
Member
Author
|
I agree since deprecations were introduced in 6.0, and as @swissspidy pointed out, there were confusing. |
Member
|
I cherry-picked this PR for WordPress 6.0 RC2 with 603ddc8. |
gziolo
added
[Package] Interface
gziolo
pushed a commit
that referenced
this pull request
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #39640 (comment).
Update deprecation messages to remove
wpprefixes and fixes alternative suggestion.Testing Instructions
Running this code in the DevTool console should result in the correct message.