Skip to content

Plugin: Remove 'gutenberg_rest_nonce' method#43805

Merged
Mamaduka merged 1 commit into
trunkfrom
remove/gutenberg-rest-nonce
Sep 4, 2022
Merged

Plugin: Remove 'gutenberg_rest_nonce' method#43805
Mamaduka merged 1 commit into
trunkfrom
remove/gutenberg-rest-nonce

Conversation

@Mamaduka
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka commented Sep 2, 2022

What?

PR removes unused gutenberg_rest_nonce method.

Why?

I don't think this AJAX callback has been used since #19178. The core version of it (wp_ajax_rest_nonce) was introduced in WP 5.3

Testing Instructions

Doesn't affect anything. Just removing dead code.

@Mamaduka Mamaduka requested review from gziolo and removed request for spacedmonkey September 2, 2022 09:21
@Mamaduka Mamaduka self-assigned this Sep 2, 2022
@Mamaduka Mamaduka added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels Sep 2, 2022
@Mamaduka Mamaduka requested a review from aristath September 2, 2022 13:27
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It was easy to miss before we put more structure into the plugin 👍🏻

@Mamaduka Mamaduka merged commit a1dcea4 into trunk Sep 4, 2022
@Mamaduka Mamaduka deleted the remove/gutenberg-rest-nonce branch September 4, 2022 09:08
@Mamaduka
Copy link
Copy Markdown
Member Author

Mamaduka commented Sep 4, 2022

Thanks for checking this on Sunday, @gziolo!

@github-actions github-actions Bot added this to the Gutenberg 14.1 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants