useSelect: add unit tests for static select mode#46606
Merged
Merged
Conversation
|
Size Change: +7 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 16, 2022
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks!
I hope you don't mind I used the opportunity to refactor fireEvent usage to user-event.
🚀
Member
Author
I actually do mind in this particular case 🙂 These are very low-level tests, some of them try to reproduce precise timing of events -- like a store update between render and effect -- and I don't want any Can you please revert the commit? |
Member
|
I tend to disagree because while I understand your rationale, I consider the |
This reverts commit f97baf6.
Member
Author
That's true, in a realistic UI a click wouldn't happen this way but for this particular test suite it's not relevant. We're doing the clicks just as an easy way to trigger something inside the component. Doing a state update, or calling a function returned from a hook. We could achieve the goal also by assigning the let innerSetFoo;
function TestComponent() {
const [ foo, setFoo ] = useState( 'foo' );
innerSetFoo = setFoo;
return <div>{ foo }</div>;
}
render( <TestComponent /> );
expect( screen ).toHaveTextContent( 'foo' );
act( () => innerSetFoo( 'bar' ) );
expect( screen ).toHaveTextContent( 'bar' ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on new
useSelectimplementation in #46538 I discovered we don't have any unit tests for the "static select mode", i.e., usinguseSelectin a non-reactive way, typically to read the latest value in an event handler:This PR fixes that omission. There is a new test that passes with the old
useSelect, and will also pass with the newuseSelectin #46538. Test-driven development!