Data: recreate listeningStores set for every markListeningStores call#46607
Merged
Conversation
|
Size Change: +19 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an
__unstableMarkListeningStoresAPI in a data registry that allow "marking" every store that was accessed in aselectcallback:We can use the stores array to, e.g., choose which stores we need to subscribe to to get updates.
This PR changes the implementation so that:
Set()for each__unstableMarkListeningStorescall, instead of reusing one global one, and merely.clear()-ing it on every call__unstableMarkListeningStores. In that case the.add()operations are redundant.This is a spinoff from #46538, where there will be optimization opportunities: we will be able to call
__unstableMarkListeningStoresonly in very specific cases, where the set of selected stores can actually change, instead calling it for every select.