WP_HTML_Tag_Processor: Rename attribute_updates to lexical_updates#47053
Merged
Conversation
2 tasks
|
Flaky tests detected in b24d6c7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3930915630
|
2 tasks
dmsnell
reviewed
Jan 11, 2023
dmsnell
reviewed
Jan 11, 2023
c7eba79 to
7f84941
Compare
7f84941 to
b24d6c7
Compare
dmsnell
approved these changes
Jan 16, 2023
Member
dmsnell
left a comment
There was a problem hiding this comment.
If it helps then I think we can merge this now as a rename and consider the deeper implications as we go. At least, this is an easy change to review. Thanks 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Rename:
$attribute_updatesmember to$lexical_updatesapply_attribute_updates()toapply_lexical_updated()class_name_updates_to_attributes_updates()toclass_name_updates_to_lexical_updatesAnd update PHPDoc and comments accordingly.
All of these are
private, so we're not breaking any APIs.Why?
To enable other kinds of updates via the same mechanism, e.g. for a prospective
set_content_inside_balanced_tags(). See #47036 and #46680 (comment) for more context.How?
It's a simple rename 😬
Testing Instructions
See unit tests.