[Block Editor - Post Template]: Fix layout styles#47221
Merged
Conversation
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
andrewserong,
annezazu,
t-hamano and
tellthemachines
|
Size Change: +16 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cb2bee4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3941658924
|
Member
|
This is looking great @ntsekouras. Before: After: |
ndiego
approved these changes
Jan 17, 2023
t-hamano
approved these changes
Jan 18, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I have confirmed that it is correctly placed in the editor and matches the front-end classname 👍
andrewserong
approved these changes
Jan 18, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Nice one, thanks for fixing this up @ntsekouras! Confirmed the issue on trunk and that this PR fixes the issue in the editor 👍
Also, kudos @tellthemachines for adding in __unstableDisableLayoutClassNames, looks like it helped make the change in this PR a simple fix 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #47129
Layout classes(
is-layout-flow) should be applied only to the wrapper element(ul) and not on the selected inner blocks wrapper throughuseInnerBlocksProps. This is already [handled server side].(#41827)Related: #44600
Testing Instructions
postand the others is the same and remains the same when we select another's post inner block.ul)Before
After
Screen.Recording.2023-01-17.at.7.04.52.PM.mov