[Block Editor]: Register the store through registerStore#47488
Merged
Conversation
ntsekouras
added
[Type] Regression
youknowriad
approved these changes
Jan 27, 2023
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
The revert is good, are the test changes related?
Contributor
Author
Yes. They were copied from Adam's PR. He removed them when the |
|
Size Change: +6 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Jan 27, 2023
Contributor
adamziel
left a comment
adamziel
left a comment
There was a problem hiding this comment.
Thank you @ntsekouras! The unit tests look good as well – thank you for remembering about them!
|
Flaky tests detected in 395639a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4023576621
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts: #47447
Why?
See details here: #47447 (comment)
We will be able to use the
registerfunction once we switch the "preferences" persistence to use the new preferences package.How?
Testing Instructions
registerStoreMost used blocksare preserved on reload.