[Mobile] - E2E tests - Add new helpers#48358
Merged
Merged
Conversation
geriux
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +2.97 kB (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c6cb481. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4353437687
|
added 4 commits
March 1, 2023 13:50
…he inline appender and the formatting options not showing up when the button gets automatically focused
…ing, openLintSettings, getButtonBlockTextInputAtPosition, addButtonWithInlineAppender and waitForElementToBeDisplayedByXPath helpers
geriux
force-pushed
the
rnmobile/add-test-suite-4
branch
from
ac47b97 to
4b5f2e2
Compare
2 tasks
dcalhoun
reviewed
Mar 3, 2023
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
This looks great! I left a few thoughts to consider.
| return ( | ||
| <View | ||
| testID={ toolbarAriaLabel } | ||
| accessibilityLabel={ toolbarAriaLabel } |
Member
There was a problem hiding this comment.
Unlike the web, this element does not appear accessible to screen readers, i.e. accessible is not enabled. Was the intent to make this selectable or should we remove accessibilityLabel?
Enabling accessible would change the interaction with the child elements, e.g. insert block button, undo button. The web has keyboard commands to "step into" an element to select a child. I do not believe mobile devices have a similar mechanism, we would likely have to recreate an experience similar to how selecting a block disables accessible on the ancestor so that descendent UI is selectable.
Member
Author
There was a problem hiding this comment.
I added these to be able to find them for E2E tests, since testID is not supported on Android we also have to add accessibilityLabel so it'd be for internal usage only.
Member
There was a problem hiding this comment.
testIDis not supported on Android we also have to addaccessibilityLabel
Aha. That is very helpful context. Thank you for explaining that. That is unfortunate. 😞 Is it worth leaving an inline comment stating it is currently only used for testing purposes?
Member
Author
There was a problem hiding this comment.
Is it worth leaving an inline comment stating it is currently only used for testing purposes?
I know we have other cases like these around the codebase, so I'm not sure if having several comments explaining why would be the best approach. I feel like if it's next to a testID it could be self-explanatory once you know it is needed for E2E tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR adds new helpers for E2E tests and it also fixes an issue where sometimes the formatting tools don't show up correctly when focusing
Buttonblocks.Why?
To simplify and avoid duplicating code some helpers were needed.
How?
It adds the following helpers:
toggleFormatting-> To be able to toggle text formatting e.g.Bold,Link.getButtonBlockTextInputAtPosition-> To get a TextInput element within a Button block.addButtonWithInlineAppender-> To be able to add new Button blocks within a Buttons block using the in-line appender.selectTextFromTextInput-> Util to select a text within TextInput.It also updates
waitForKeyboardToBeHiddento take into account when the device is in Lanscape mode for iOS.Testing Instructions
CI checks should pass on both Gutenberg and Gutenberg Mobile.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A