Tag Cloud Block: Fix outline style not applied in editor#49248
Closed
t-hamano wants to merge 1 commit into
Closed
Conversation
|
Size Change: +116 B (+0.01%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Regression
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks, for the continued efforts on these server-side rendered blocks @t-hamano 👍
Can you refresh my memory on why we are stripping the block's className attribute when skipBlockSupportAttributes is passed to ServerSideRender?
CSS classes produced by block supports aren't included in that attribute. Stripping it means we lose the Block Styles class as in this use case, along with any other custom CSS class the use has applied to the block.
Removing className from the attributes stripped allows the Block Style to work as normal. At least it did for me in a quick test here.
Before we add extra CSS as proposed here, I'd like to make sure we weren't too aggressive in the removal of attributes that were supposed to be stripping only block support styles and classes.
What do you think?
Contributor
Author
|
Thank you for the review, @aaronrobertshaw! I have looked back in the past and seen comments here about how additional CSS classes should be handled.
However, from the PR that was subsequently submitted, it appears that I was proceeding under the assumption that duplication of additional CSS classes is naturally a problem as well as style and CSS classes produced by block support:
Should we rethink whether duplicating additional CSS is a problem? |
Contributor
|
This looks like an issue in the way we render server side blocks in the editor. I'd be very hesitant to add this CSS because it's just masking the problem and we'll end up having to do this for all server side blocks. |
Contributor
Author
|
@scruffian The ideal solution would be to render this block in JavaScript, but I think it might be difficult to implement the As stated in this comment, if the additional CSS is not removed with |
Contributor
|
I wonder if the solution is to remove the wrapper when this is rendered, so that the markup of the block in the editor is closer to the frontend. |
t-hamano
force-pushed
the
tag-cloud-outline-style-editor
branch
from
34b7904 to
4c44aae
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Is the new useServerSideRender something we can use to solve the markup discrepancy between server and frontend? Otherwise we should just land this PR. |
Contributor
Author
|
The issue has been resolved with the merge of #74228. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #49226
Related to: #44439
What?
This PR fixes a problem where styles aren't applied correctly when the outline style is applied to the tag cloud block in the editor.
Why?
In #44439,
skipBlockSupportAttributeswas added to theServerSideRendercomponent to prevent duplication of block support styles and additional CSS classes. As a result, flex layout is now applied only to block wrapper elements, and styles are not applied to server-side renderedp.wp-block-tag-cloud.Testing Instructions
Before
After