Tweak edit site resizable frame handle#50878
Merged
Merged
Conversation
richtabor
added
the
[Feature] Site Editor
|
Size Change: +38 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
apeatling
approved these changes
May 23, 2023
Contributor
apeatling
left a comment
apeatling
left a comment
There was a problem hiding this comment.
Looks good. I didn't notice as much of a change in length as your after video, but it's a solid improvement 👍
Contributor
|
Nice improvement. For some reason the exit animation doesn't work of the handle (should reverse and slide back in to frame) but that can be treated as a separate issue. |
Member
Author
Yea, I wasn’t too sure about that. Let’s follow up to tweak that bit. |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Vertically centers the new resize handle (#49910), applies standard metrics to the handle, adjusts the hover scaling animations, and ensures the handle stays in its focused state as you're dragging it.
Why?
Makes it feel nicer to interact with.
Testing Instructions
Screenshots or screencast
Before
CleanShot.2023-05-23.at.09.04.31.mp4
After
CleanShot.2023-05-23.at.09.01.08.mp4