gutenberg_add_global_styles_for_blocks should add all global styles.#52228
Closed
zpericic wants to merge 1 commit into
Closed
gutenberg_add_global_styles_for_blocks should add all global styles.#52228zpericic wants to merge 1 commit into
zpericic wants to merge 1 commit into
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @zpericic! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
agugic2
approved these changes
Oct 17, 2023
agugic2
approved these changes
Oct 17, 2023
agugic2
approved these changes
Oct 17, 2023
agugic2
approved these changes
Oct 17, 2023
Author
|
This is resolved in Wordpress by 4174 and merged in Trac 56254. Error still persist if guttenberg is active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52276
Regression after #50310
What?
Load all elements global styles for non 'core/' blocks.
Why?
Any style with $metadata['path'] will be skipped if does not have element starting with 'core/'. We should use 'wp_add_inline_style' for all global styles.
How?
Call 'wp_add_inline_style' for all block global styles.
Testing Instructions