Site editor: revert layout.js changes from Update frame resizing#52311
Closed
ramonjd wants to merge 2 commits into
Closed
Site editor: revert layout.js changes from Update frame resizing#52311ramonjd wants to merge 2 commits into
ramonjd wants to merge 2 commits into
Conversation
|
Size Change: -415 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Member
Author
|
E2E fails are the same ones failing everywhere |
ramonjd
added
[Feature] Site Editor
Member
Author
|
Closed in favor of #52443 |
priethor
added
[Focus] Accessibility (a11y)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Maybe resolves #51267
Rolls back the changes made to packages/edit-site/src/components/layout/index.js in #49910.
Why?
Frame resizing is not keyboard accessible
How?
Manually reverted the changes from c689d9f by comparing with the previous version in d746e55
Testing Instructions
Open the site editor in view mode.
Ensure the canvas is resizable with a keyboard and with a mouse.
Screenshots or screencast