Auto-inserting blocks: Add block icon to block inspector panel toggles#54029
Merged
Conversation
ockham
added
[Feature] Block API
19 tasks
|
Size Change: +94 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 96b03f7cc410cefd927f515b58add3dc32e95df5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6016004818
|
gziolo
reviewed
Aug 30, 2023
ockham
force-pushed
the
add/auto-inserting-block-icon-inspector-panel
branch
from
ef002f8 to
c259ddc
Compare
ockham
force-pushed
the
add/auto-inserting-block-icon-inspector-panel
branch
from
c259ddc to
2aa4888
Compare
Contributor
|
Thanks for the ping. You know, I prefer them on the left, consistent with other toggles. Nevertheless I also hear the argument that this isn't a 1:1 comparison with existing toggles, that the interface on the left is the block information, with iconography and anything else, and the toggle being separate from that. So it's not a strong opinion on my part, and I'm happy to defer to Jay, or perhaps @richtabor if they feel otherwise. |
gziolo
approved these changes
Aug 31, 2023
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Code-wise, this looks good. Let's wait for 👍🏻 from the design team.
Contributor
|
I don't love the toggles on the right, but it's not offensive to me either. If we want to include the block icon then I can't really think of another layout configuration. Perhaps Rich has an idea. As a follow-up we might consider adding a 
|
Contributor
Author
|
Thanks all! I'll go ahead and merge this, and will file a follow-up issue about making a |
ockham
added a commit
that referenced
this pull request
Sep 4, 2023
#54029) Add block icons to block inspector panel toggle labels, and right-align the toggles.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add block icons to block inspector panel toggle labels, and right-align the toggles.
Why?
To match the original mockup from #52969. (Note that we don't seem to have precedent for right-aligning toggles; this was briefly discussed, resulting in a tentative okay for trying out this pattern for this new feature.)
How?
A bit of applied flexbox magic.
Testing Instructions
If you prefer video over text, there's a 5-minute demo in the PR description of #52969 (still using the "Before" styling for the toggles, but you get the idea).
Screenshots or screencast