Editor: reinstate anonymous callback for saved post state#56529
Merged
Conversation
ramonjd
added
[Type] Regression
|
Size Change: +2 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Nov 26, 2023
Contributor
There was a problem hiding this comment.
It seems like there was a pretty valid reason for not passing the event object in this instance - more detail here.
It was a long time ago, so may not be valid anymore, but it seems like it is safe to revert this to get tests passing again while that is investigated further.
Member
|
TIL, and thanks for catching it so quickly! It’s my bad FWIW, since I originally suggested it in a code review. |
Member
Author
|
All good! 🙇🏻 |
Contributor
That's a good TIL for me, as well, I'll be sure to double-check function signatures when passing function references around in future, too! |
Contributor
Same. This was a good reminder, thank you @ramonjd ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts this line merged in #56502.
Why?
The savePost action in the editor store doesn't expect to be passed an event object.
See the relevant test.
How are you?
Fine thanks!
Testing Instructions
Run the tests!
npm run test:unit packages/editor/src/components/post-saved-state/test/index.js