Performance: Improve opening inserter in post editor#57006
Merged
Conversation
ntsekouras
added
[Feature] Inserter
ntsekouras
requested review from
ajitbohra,
ellatrix,
fabiankaegy,
juanmaguitar,
ndiego and
ryanwelcher
as code owners
|
Size Change: +87 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Dec 13, 2023
| if ( ! inserter ) { | ||
| return false; | ||
| } | ||
| const { blocks } = __experimentalGetParsedPattern( |
Member
There was a problem hiding this comment.
I see we're still parsing patterns, but not all of them, but only until .some detects one of them as allowed. Is that the optimization?
Contributor
Author
There was a problem hiding this comment.
Yes, that's it and in most cases we parse just the first pattern.
|
Flaky tests detected in eb576e9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7192803009
|
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Performance: Improve opening inserter in post editor * make selector private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the performance when opening the main inserter in post editor by introducing a new selector to check if we have at least one available allowed pattern. The new selector does exactly what the
__experimentalGetAllowedPatternsdoes, but doesn't need to parse all patterns and of course returns a boolean value.In my profiling the tasks from
~116msis down to~6ms.Notes for follow ups
Testing Instructions