Fix BlockSwitcher checks for showing a Dropdown menu or not#57047
Merged
Conversation
ntsekouras
added
[Type] Bug
ntsekouras
commented
Dec 14, 2023
| menuProps={ { orientation: 'both' } } | ||
| > | ||
| { ( { onClose } ) => | ||
| showDropDown && ( |
Contributor
Author
There was a problem hiding this comment.
All these are whitespace changes because I removed the showDropDown check, since we know we should render a Dropdown.
ellatrix
approved these changes
Dec 14, 2023
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Sure! Could we make lighter has* selectors though? 😄
|
Size Change: -8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 06b0f1a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7206568112
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a bug I noticed while reviewing this PR. Right now if a block has no styles or block transformations, but has pattern transformations we don't render the Dropdown.
Testing Instructions