Reduce clearance around frame in focus mode#57124
Closed
richtabor wants to merge 1 commit into
Closed
Conversation
richtabor
added
[Type] Enhancement
|
Size Change: -8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1f2aa6d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7227433766
|
jameskoster
previously approved these changes
Dec 18, 2023
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
+1, we can certainly reduce now that there's no need to accommodate the 'Back' button.
Contributor
I spoke too soon. If you edit a template, select a template part, then click 'edit' in the block toolbar, the 'back' button gets obscured: |
Contributor
|
Jay catches a good caveat we should address before merging. That is to say, I expect that in-canvas back button to be retired in favor of a back button in the document title interface. So eventually we can land this, and we should, because the new clearance avoids the tangent with the site logo. |
Member
Author
For additional context, we're referring to the "Back" button here, to be added to the template parts focus view:
|
richtabor
requested review from
jameskoster
and removed request for
jameskoster
richtabor
dismissed
jameskoster’s stale review
Dismissing as we found a blocker.
Contributor
|
Indeed, I was referring to the same, that we end up with a single "back" button affordance, the one that exists in the top toolbar, not in the canvas. The document title will need to appear regardless, when you enter focus mode. |
Member
|
#58528 reduced the size of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We don't need this clearance to be quite so large—just thick enough to provide context that this is a focused view for editing this site component (patterns, template part, etc).
Reducing this also helps with the transitions that occur when you navigate through to a pattern/template part; as there is less "jump" between clearances.
Related in part to #57023.
How?
Small CSS change.
Testing Instructions
Screenshots or screencast