Image block: remove a block editor store sub#57232
Merged
Merged
Conversation
ellatrix
requested review from
artemiomorales and
michalczaplinski
as code owners
|
Size Change: -71 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Member
michalczaplinski
approved these changes
Jan 2, 2024
Contributor
michalczaplinski
left a comment
michalczaplinski
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks @ellatrix!
I resolved the merge conflict but there might be additional potential for perf improvements in the code that was merged in the meantime.
|
Flaky tests detected in f89cc95. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7687625546
|
ellatrix
force-pushed
the
remove/image-subs
branch
from
7457a2a to
6a91130
Compare
ellatrix
changed the title
ellatrix
force-pushed
the
remove/image-subs
branch
from
b1586f8 to
f89cc95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
While this may be negligible because there are not usually many image block in a post, it's still good practice to avoid block editor store subscription if they're not needed.
isSelected, which will be false for a multi selection.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast