Table: Remove unnecessary margin override in editor styles#57699
Merged
Conversation
andrewserong
added
[Type] Bug
andrewserong
requested review from
aaronrobertshaw,
ramonjd and
tellthemachines
andrewserong
changed the title
|
Size Change: -16 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jan 9, 2024
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR! Change LGTM and works correctly in testing. This should also fix #55409.
Contributor
Author
|
Thanks for the quick review! 🙇
It looks like that issue has a subtle difference as it's talking about the rule in Unfortunately I think that one might be a little trickier to fix as there could be Classic themes out in the wild that expect that |
aaronrobertshaw
approved these changes
Jan 9, 2024
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM also 👍
Unfortunately I think that one might be a little trickier to fix as there could be Classic themes out in the wild that expect that 1em bottom rule to be applied
Agreed. I don't think that should block this PR landing.
Contributor
Author
|
Thanks folks! |
andrewserong
removed
the
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the Table block's unnecessary
margin: 0;rule in its editor styles. Since this doesn't affect the styles on the site frontend, this shouldn't be a breaking change.Why?
The browser default
figureelement margins are already overridden via a lower specificity:where()rule here:gutenberg/packages/block-library/src/common.scss
Line 161 in 9c5ce7e
The higher specificity rule in
.wp-block-tablehad the unintended effect of overriding the low specificity layout rules (see: #47858 for when the layout rules were lowered in specificity). The result is that within the editor, the default layout block spacing is being overridden for the table block, when it shouldn't be.How?
Remove the Table block's unnecessary
margin: 0;rule in its editor styles.Testing Instructions
margin: 0rule prevents there being a space before the block within the editor, however on the site frontend that gap is present.Testing Instructions for Keyboard
Screenshots or screencast