Global style changes: update sprintf calls using _n#59160
Merged
Conversation
ramonjd
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -10 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Feb 19, 2024
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your follow-up 😊
Member
Author
No, thank you for being very attentive on a Monday morning! 🙇🏻 |
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 5044d4c |
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up for #59055 to remove first
sprintfargWhy?
@t-hamano very rightly pointed out that I didn't need the first argument as it didn't appear in the string replacement.
I was too busy copying and pasting to notice.
Thank you!
Testing Instructions
Covered by unit tests.
npm run test:unit packages/block-editor/src/components/global-styles/test/get-global-styles-changes.jsThe JS tests should pass.