Site Editor: Restore the back button when navigating to the template from the home page.#59639
Merged
Conversation
…from the home page
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -9 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
requested review from
a team,
andrewserong and
chad1008
and removed request for
a team
ntsekouras
approved these changes
Mar 7, 2024
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
I think it's way better than trunk this way. I tested with multiple entities/scenarios and didn't spot anything bad. Thanks!
Contributor
|
Noting that this regression was introduced during the 6.5 cycle. Loss of the @youknowriad are you targeting this for WP 6.5? |
Contributor
Author
|
yes, I think it's important. |
Contributor
|
Thanks for the ping, I missed the boat in reviewing before merge, but this is testing well for me, too! |
getdave
added a commit
that referenced
this pull request
Mar 11, 2024
…from the home page (#59639) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release: 67b216a |
getdave
added
Backported to WP Core
getdave
added a commit
that referenced
this pull request
Mar 12, 2024
…from the home page (#59639) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
Member
|
Thanks for fixing this @youknowriad ❤️ |
bph
added
the
[Feature] Site Editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a regression introduced in #58710
What?
When you have a static home page and you open the site editor and navigate to its template, the "back" button was not visible in trunk.
It's actually a bit tricky to get this right, we were checking that we were coming from a defined postType and postId to show the button or not, the current PR will show the button when we navigate from the editor canvas regardless of the previous thing that was rendered in the canvas.
Obviously, this is not necessarily perfect but I think it's better than what's currently in trunk but let make sure to test all kind of post types in the site editor.
Testing Instructions
1- Have a fixed home page
2- Open the site editor
3- Go the editor
4- Click outside post blocks
5- A snackbar shows up inviting you to switch to template
6- Click edit template
7- Back button is visible in the document bar.