Enable template preview in post editor for non administrators#60447
Merged
fabiankaegy merged 4 commits intoApr 17, 2024
Conversation
fabiankaegy
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
4 tasks
|
Size Change: +61 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
fabiankaegy
requested review from
Mamaduka,
getdave,
glendaviesnz,
noisysocks,
talldan and
youknowriad
fabiankaegy
commented
Apr 3, 2024
Member
Author
There was a problem hiding this comment.
@getdave I'd love to get your take on this. I feel like there has to be a better way to do this.
essentially what we want here is a preview-only mode of the navigation block that readers a full rich preview of the navigation menu in question for any users that are able to view the item in the rest API but cannot edit it.
We recently added this same thing to the template part block in #60326
youknowriad
reviewed
Apr 4, 2024
youknowriad
reviewed
Apr 4, 2024
| supportsTemplateMode && | ||
| isViewable && | ||
| canEditTemplate && | ||
| canViewTemplate && |
Contributor
There was a problem hiding this comment.
This is potentially the most impactful change because it's not clear exactly what the availability of the template changes in the editor.
fabiankaegy
force-pushed
the
feature/enable-template-preview-for-non-administrators
branch
2 times, most recently
from
7e095bd to
bd076c1
Compare
fabiankaegy
force-pushed
the
feature/enable-template-preview-for-non-administrators
branch
from
bd076c1 to
0eb074a
Compare
Member
Author
|
@youknowriad I cut this down to only include the most fundamental changes. The additional updates to the template part block were moved here: #60787 And a new issue for the Navigation block was created #60809 Let me know if you want me to change anything else here or whether you agree this is ready to get merged :) |
youknowriad
approved these changes
Apr 17, 2024
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for your work here. This looks good.
fabiankaegy
deleted the
feature/enable-template-preview-for-non-administrators
branch
Mamaduka
reviewed
Jul 11, 2024
Comment on lines
+154
to
+156
| const _canEditTemplate = | ||
| select( coreStore ).canUser( 'create', 'templates' ) ?? false; | ||
|
|
Member
There was a problem hiding this comment.
Is this check correct? Should it check if a user can edit templates or template parts?
Member
Author
There was a problem hiding this comment.
@Mamaduka As far as I know they use one singular REST Controler for both. And that lives under templates 🤔
I may of course have missed something
Member
There was a problem hiding this comment.
They have different rest bases - templates and template-parts.
I'm asking because I'm working to bulk update canUser selectors, and I would instead use the correct post type for new checks. See #63415.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closing #60316. Supersedes #58301 and follows #60317 & #60326
Why?
To allow non administrators to preview templates whilst editing content in the regular post editor
How?
Adjusting the conditions when to display templates to allow users that can only view templates to still preview them.
Testing Instructions