Navigation: Remove unnecessary __experimentalStyle#60965
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
left a comment
There was a problem hiding this comment.
Yeah, that looks correct to me. I believe we should have this covered with e2e tests too
|
@MaggieCabrera Thanks for the review!
Isn't the default color tested here? This PR only removes duplicate |
|
For now, I would like to merge this PR. If we need additional e2e testis, I'd be happy to do that as a follow-up. |
Closes #59142
Rleated to #51710, #52579
What?
This PR removes unnecessary
__experimentalStylefrom the Navigation menu.Why?
From what I've researched, this is an accidental regression caused by the timing of two PRs being merged.
Below are the PRs related to this issue and the dates and times they were merged.
__experimentalStylehas been removed to theblock.json(Source)__experimentalStylehas been re-added to theblock.json. (Source)As you can see, the times when the two PRs were merged are very close. Perhaps the latter PR did not include the former PR, so
__experimentalStylewas added unintentionally.Testing Instructions
Since the stylesheet already exists, there will be no side effects of deleting it. As shown below,
color: inherit;should still be applied to links in the navigation block.